Add max_heap_size option and related error variant #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration: this PR adds a new
max_heap_size
option to RuntimeOptions. Merging the provided setting into any existingisolate_options
if given.Using a
CancellationToken
to sync the termination across both inner and outer runtime, as just terminating the isolate leaves tokio hanging... needed to modify the on_block call to abort its inner future also.LMK if you think it's useful, or if there's a better way to go about it.