Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better help output #24958

Merged
merged 20 commits into from
Aug 12, 2024
Merged

feat: better help output #24958

merged 20 commits into from
Aug 12, 2024

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Aug 8, 2024

Additionally adds an internal JSON help output.
Screenshot 2024-08-09 at 13 33 38

Screenshot 2024-08-09 at 13 34 02

@crowlKats crowlKats marked this pull request as draft August 8, 2024 15:46
@crowlKats crowlKats marked this pull request as ready for review August 9, 2024 07:54
@bartlomieju
Copy link
Member

FYI ./target/debug/deno --help prints nicely with colors, but ./target/debug/deno help has no colors whatsoever.

@bartlomieju
Copy link
Member

Also on my machine I don't see descriptions being grayed out:
Screenshot 2024-08-09 at 23 28 11

bartlomieju added a commit that referenced this pull request Aug 11, 2024
This commit stabilizes HMR functionality and renames
`--unstable-hmr` to `--watch-hmr`. The `--unstable-hmr`
flag is still working, but hidden from the help output.
It will be removed in Deno 2.

Once #24958 lands
we should improve grouping of `--watch` and `--watch-hmr`
flags.
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crowlKats crowlKats merged commit e5f0058 into denoland:main Aug 12, 2024
17 checks passed
@crowlKats crowlKats deleted the better-help-output branch August 12, 2024 15:55
@littledivy
Copy link
Member

Reason for reverting tokio upgrade: tokio-rs/tokio#6767

@robtfm
Copy link

robtfm commented Sep 20, 2024

Reason for reverting tokio upgrade: tokio-rs/tokio#6767

looks like upstream is fixed, could this be unfrozen now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants