-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support recording canvas in iframe and shadow dom #1428
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: db60778 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/rrweb/src/record/observers/canvas/canvas-manager.ts
Resolves getsentry/sentry-javascript#10758 rrweb PR: rrweb-io#1428 <details> <summary> Before </summary> <p> Red square is on the main page;<br> Green is inside the shadow dom on the main page;<br> Blue one is within the iframe;<br> Pink is inside the shadow dom within the iframe. </p> <video src="https://github.com/rrweb-io/rrweb/assets/25964451/110f1e36-0a74-4d1c-9cd7-d28eba95af05"/> </details> <details> <summary> After </summary> <video src="https://github.com/rrweb-io/rrweb/assets/25964451/902495b5-e1b3-40d0-85af-6aeff58a5628"/> </details>
It still working? |
Hello, we are using rrweb and it's been a great product for capturing replays! We have also come across edge cases where we are not capturing It looks like this PR has been "stuck" in the current state for the last 6 months. What is the next step to move forward with this? Is it awaiting merge conflict resolution by original author or would it be ok if we or others try to help resolve the conflict? (Asking as I'm still new to open source and not sure about etiquette, thanks for your consideration!) |
We're also waiting for this PR approval as we'd like to use rrweb with flutter canvaskit too. Hope it will be merged soon! |
Resolves #1412, resolves #1081
Before
Red square is on the main page;
Green is inside the shadow dom on the main page;
Blue one is within the iframe;
Pink is inside the shadow dom within the iframe.
canvas-iframe-before.mov
After
canvas-iframe-after.mov
Key differences from existing PRs:
sampling: 'all'
modeShadowDomManager
is utilized for obtaining information about the shadow DOMs, rather than looping through all the elements on the pagetakeCanvasSnapshots
loop on reset