feat: support recording canvas in iframe and shadow dom #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@p-mazhnik This is great, I can take a look at this next week |
|
@p-mazhnik Do you have "Allow edits by maintainers" enabled on this PR? I can't seem to push to your branch |
I do. I've added you to my fork as well just in case |
|
@p-mazhnik thanks, ah I think the perm issues were due to tags |
billyvg
reviewed
May 28, 2024
billyvg
approved these changes
May 29, 2024
|
Thanks for the contribution @p-mazhnik! Sorry it took so long to merge. |
billyvg
added a commit
that referenced
this pull request
Oct 29, 2024
`reset()` gets called when we stop a recording in progress. There is no reason to re-initialize the worker in `reset()` as you would need to call `record()` to start recording again, which would start a new worker. This was introduced in #168.
billyvg
added a commit
that referenced
this pull request
Oct 31, 2024
`reset()` gets called when we stop a recording in progress. There is no reason to re-initialize the worker in `reset()` as you would need to call `record()` to start recording again, which would start a new worker. This was introduced in #168.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves getsentry/sentry-javascript#10758
rrweb PR: rrweb-io#1428
Before
Red square is on the main page;
Green is inside the shadow dom on the main page;
Blue one is within the iframe;
Pink is inside the shadow dom within the iframe.
canvas-iframe-before.mov
After
canvas-iframe-after.mov