Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-563: Add option to manually resize column in column menu #606

Closed
wants to merge 2 commits into from

Conversation

gibsonliketheguitar
Copy link
Contributor

@gibsonliketheguitar gibsonliketheguitar commented Dec 20, 2021

The feature is pretty much done. #563

  • Add an option called 'Resize column' in the column menu.

However, there is a bug with React Data Grid.
After dragging and resizing the column, you will NOT be able to manually update the column width with this feature.

I've confirmed there is no issue with rowy state manually and with react-dev tools and
I've also built a smaller version of this feature to confirm the bug.
I started digging into the library, and believe React.memo is doing something weird. Will do the more extensive tests when I have time.

I will open a ticket with React-Data-Grid and see if they can help.

@gibsonliketheguitar gibsonliketheguitar changed the title Feat 563 - Add option to manually resize column in column menu feat 563 - Add option to manually resize column in column menu Dec 27, 2021
@gibsonliketheguitar gibsonliketheguitar changed the title feat 563 - Add option to manually resize column in column menu feat-563: Add option to manually resize column in column menu Dec 27, 2021
@notsidney
Copy link
Contributor

Hi @gibsonliketheguitar, is our use of React.memo on the table preventing this re-render from occurring? Can we just add another dependency to the memo?

@gibsonliketheguitar
Copy link
Contributor Author

@notsidney its RDG's memo function handling column resize. I build a smaller application to confirm the issue

I can double check ROWY memos.

@notsidney notsidney marked this pull request as draft January 28, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants