This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
define M_PI if not defined #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in progress
Karsten1987
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
I was wondering for a moment if we should apply the same way of defining M_PI here as we did in ros/urdfdom_headers@ed597eb, but then again it's a test. So if CI is passing, I believe it's fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmath doesnt provide M_PI on Windows, this test gets the definition from "urdf_model/pose.h" that is not very robust to changes.
This change is needed to be start tracking upstream
urdfdom_headersagain.Connects to ros2/ros2#465