Add an option to publish TwistStamped #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamaki Nishino <[email protected]>
ahcorde
requested changes
Apr 3, 2024
Signed-off-by: Tamaki Nishino <[email protected]>
Signed-off-by: Tamaki Nishino <[email protected]>
I updated the README and add an argument to the launch file. |
ahcorde
approved these changes
Apr 3, 2024
|
Thank you for the contribution @otamachan |
|
@ahcorde Will this be added to the |
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Tamaki Nishino <[email protected]> (cherry picked from commit 76cd650) # Conflicts: # README.md # src/teleop_twist_joy.cpp
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Tamaki Nishino <[email protected]> (cherry picked from commit 76cd650) # Conflicts: # README.md # src/teleop_twist_joy.cpp
|
Hi @YBachmann there are two options:
|
Merged
ahcorde
added a commit
that referenced
this pull request
Jun 14, 2024
* Add an option to publish TwistStamped (#42) Signed-off-by: Tamaki Nishino <[email protected]> (cherry picked from commit 76cd650) # Conflicts: # README.md # src/teleop_twist_joy.cpp * resolved merge conflicts (#47) Co-authored-by: Yannic Bachmann <[email protected]> --------- Co-authored-by: Tamaki Nishino <[email protected]> Co-authored-by: Yannic Bachmann <[email protected]> Co-authored-by: Yannic Bachmann <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Tamaki Nishino <[email protected]> (cherry picked from commit 76cd650) # Conflicts: # README.md # src/teleop_twist_joy.cpp Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Tamaki Nishino <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ros-teleop/teleop_tools#54, this PR adds an option
publish_stamped_twistto publishTwistStampedfor/cmd_veltopic. This PR also adds a parameter forframe_idfor its header.I didn't change the default type for now.