Possibility to use TwistStamped (still Twist by default) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
reviewed
Nov 3, 2020
bmagyar
reviewed
Nov 3, 2020
bmagyar
requested changes
Nov 3, 2020
klintan
force-pushed
the
twist-stamped
branch
from
a8bc461
to
a7fbbd0
Compare
Sorry for the slow response on this one. It should all be addressed now as far as the feedback goes. edit: let me know if there is anything else :) |
|
This PR references ros-navigation/navigation2#1594. See also the discussion there. |
bmagyar
approved these changes
Mar 21, 2021
|
Whoops, I didn't read that this would add an option for twist stamped |
2 tasks
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ros2_control decided to go for TwistStamped (which I can understand because of the extra info + timestamp you get) however that makes it incompatible with this library. This is a suggested fix for that, if you feel this is an option, i'll go ahead and change the other modules (joy and mouse) the same way.
Let me know what you think :)
PS. would be good to create a foxy-devel branch as well.