rename rosidl_generator_c 'namespace' to rosidl_runtime_c #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
This was referenced Apr 11, 2020
Signed-off-by: Dirk Thomas <[email protected]>
dirk-thomas
force-pushed
the
dirk-thomas/rename-namespaces2
branch
from
4ad84af
to
c6b5d38
Compare
cottsay
approved these changes
Apr 11, 2020
dirk-thomas
added a commit
that referenced
this pull request
Apr 11, 2020
Signed-off-by: Dirk Thomas <[email protected]>
dirk-thomas
commented
Apr 11, 2020
| @@ -527,7 +527,7 @@ int test_unbounded_sequences() | |||
| } | |||
|
|
|||
| // uint8_values | |||
| res = rosidl_generator_c__uint8__Sequence__init(&seq->uint8_values, ARR_SIZE); | |||
| res = rosidl_runtime_c__int8__Sequence__init(&seq->uint8_values, ARR_SIZE); | |||
There was a problem hiding this comment.
No idea how I broke this doing search & replace, but this changes from uint8 to int8 results in a compiler warning. See #460.
dirk-thomas
added a commit
that referenced
this pull request
Apr 11, 2020
Signed-off-by: Dirk Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #442 as part of #446 to match namespace with the package the name the symbols are defined in. Similar to #456.
The two commits in this PR should not be squashed.
Only Linux with linter tests since the change shouldn't have any runtime impact (if it compiles successfully):