Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename rosidl_generator_c namespace to rosidl_runtime_c #150

Merged
merged 1 commit into from
Apr 11, 2020
Merged

rename rosidl_generator_c namespace to rosidl_runtime_c #150

merged 1 commit into from
Apr 11, 2020

Conversation

dirk-thomas
Copy link
Member

Related to ros2/rosidl#458.

@dirk-thomas dirk-thomas self-assigned this Apr 11, 2020
@dirk-thomas
Copy link
Member Author

The GitHub actions are expected to fail since they don't use the changes in the referenced PRs.

@rotu
Copy link
Collaborator

rotu commented Apr 11, 2020

FYI: submitted ros-tooling/action-ros-ci#157 to support testing these sorts of PRs.

@rotu
Copy link
Collaborator

rotu commented Apr 11, 2020

LGTM once ros2/rosidl#458 gets merged and CI passes.

rotu
rotu requested changes Apr 11, 2020
View reviewed changes
Copy link
Collaborator

@rotu rotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending merge of ros2/rosidl#458

@dirk-thomas
Copy link
Member Author

@rotu Once the CI build in the referenced ticket passed the plan is to merge all PRs at once. Holding some PRs back until their custom actions pass (because they are not able to work for cross-repo changes) is not desired since during that time window the build of ROS 2 would be broken.

@rotu
Copy link
Collaborator

rotu commented Apr 11, 2020

@rotu Once the CI build in the referenced ticket passed the plan is to merge all PRs at once. Holding some PRs back until their custom actions pass (because they are not able to work for cross-repo changes) is not desired since during that time window the build of ROS 2 would be broken.

Once the CI in the referenced ticket passes, rerun this repo's CI. If there are no more commits on this branch and it passes CI, you can assume my approval. Github doesn't support "merging multiple PRs at once" - merging is an atomic operation in only one repo at a time and the point of CI is to reduce errors in this and other human operations.

@dirk-thomas dirk-thomas reopened this Apr 11, 2020
@dirk-thomas dirk-thomas merged commit 5c6b187 into master Apr 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/rename-namespaces2 branch April 11, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

@rotu rotu rotu approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirk-thomas @rotu @cottsay