Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[galactic] Enable sanitizers only if code actually can run (#572) #952

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

jacobperron
Copy link
Member

Backport #572 to Galactic.

Uses check_cxx_source_runs instead of check_cxx_source_compiles so that
sanitizers are disabled in an environment that they cannot run in. In
particular this disables the sanitizers on the buildfarm because they're
run in docker containers without the ptrace capability. This should fix
the test test_ros2_message failing on the ROS buildfarm.

Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
@jacobperron jacobperron self-assigned this Jan 31, 2022
@jacobperron jacobperron requested a review from a team as a code owner January 31, 2022 20:04
@jacobperron jacobperron requested review from gbiggs and lihui815 and removed request for a team January 31, 2022 20:04
@gbiggs
Copy link
Member

gbiggs commented Jan 31, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@gbiggs
Copy link
Member

gbiggs commented Feb 1, 2022

The test failure doesn't look related to this PR.

@jacobperron
Copy link
Member Author

We're running a Rolling version of linters against Galactic, which I think is why we are seeing ament_cpplint and ament_uncrustify errors.

I haven't seen the records_sensor_data test failure before. It appears on both the ci.ros2.org job and the GPr job.

@jacobperron
Copy link
Member Author

I haven't seen the records_sensor_data test failure before. It appears on both the ci.ros2.org job and the GPr job.

Ah, it's a known flake: #766

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member Author

jacobperron commented Feb 7, 2022

See #959 for a lint CI fix.

@jacobperron jacobperron merged commit b2ffb95 into galactic Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/galactic_backport_572 branch February 7, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants