Add option in ros2 topic pub to wait for N matching subscriptions, use N=1 by default when combined with --times #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e N=1 by default Signed-off-by: Ivan Santiago Paunovic <[email protected]>
audrow
approved these changes
May 27, 2021
fujitatomoya
approved these changes
May 27, 2021
clalancette
reviewed
May 28, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
@ros-pull-request-builder retest this please |
|
I've added a test in 19ce636. |
hidmic
approved these changes
May 31, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
CI:
|
clalancette
reviewed
Jun 1, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
I have changed the default value according to the offline discussion in 93cf847. |
clalancette
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
This all seems reasonable to me now, so I'm approving. A few things before we merge this:
- Green CI.
- I think a release note in https://github.com/ros2/ros2_documentation/blob/rolling/source/Releases/Release-Humble-Hawksbill.rst is appropriate.
- I think we should get one more approval before merging this.
hidmic
approved these changes
Jun 2, 2021
|
CI:
|
|
CI is green, there're two approvals, PR to document this in the |
ivanpauno
changed the title
delete-merged-branch
bot
deleted the
ivanpauno/ros2-topic-pub-wait-matching-subscriptions
branch
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #641, seems to be a better idea to me.