Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the triggering of guard conditions. (backport #504) #505

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 11, 2024

When a guard condition goes active, we have to remember to increase the trig_idx so we look at the next trigger. Otherwise, we can get into situations where we skip a triggered member.

This is a regression from #482 . This fixes #494 and should also fix ros2/rclcpp#2502 . @Crola1702 FYI.

This should also be backported to Jazzy.


This is an automatic backport of pull request #504 done by Mergify.

When a guard condition goes active, we have to remember
to increase the trig_idx so we look at the next trigger.
Otherwise, we can get into situations where we skip a
triggered member.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 899bbdf)
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit cffdd90 into jazzy Jul 12, 2024
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-504 branch July 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants