Fix the triggering of guard conditions. #504
Conversation
When a guard condition goes active, we have to remember to increase the trig_idx so we look at the next trigger. Otherwise, we can get into situations where we skip a triggered member. Signed-off-by: Chris Lalancette <[email protected]>
|
Here's regular CI on this:
But here is also a run with all RMWs except for CycloneDDS disabled:
|
|
Here's another try of CycloneDDS-only, with a fix in the CI scripts:
|
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/preparing-for-rolling-sync-2024-07-11/38526/2 |
|
Since we haven't run CI on just CycloneDDS in a long time, here is a run of it on
|
|
All right. Regular CI went swimmingly. CI on CycloneDDS only wasn't perfect, but it definitely showed less failures than without this PR. After poking at some of the other issues locally, I'm convinced that those are for other reasons. So with all of that, and the approval, I'm going to go ahead and merge this, and also backport to Jazzy. |
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
When a guard condition goes active, we have to remember to increase the trig_idx so we look at the next trigger. Otherwise, we can get into situations where we skip a triggered member. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 899bbdf)
When a guard condition goes active, we have to remember to increase the trig_idx so we look at the next trigger. Otherwise, we can get into situations where we skip a triggered member. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 899bbdf) Co-authored-by: Chris Lalancette <[email protected]>
|
@Mergifyio backport iron |
✅ Backports have been created
|
When a guard condition goes active, we have to remember to increase the trig_idx so we look at the next trigger. Otherwise, we can get into situations where we skip a triggered member. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 899bbdf) # Conflicts: # rmw_cyclonedds_cpp/src/rmw_node.cpp
When a guard condition goes active, we have to remember to increase the trig_idx so we look at the next trigger. Otherwise, we can get into situations where we skip a triggered member.
This is a regression from #482 . This fixes #494 and should also fix ros2/rclcpp#2502 . @Crola1702 FYI.
This should also be backported to Jazzy.