-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamps to rmw-internal structures. #200
Conversation
Connects to ros2/design#259. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should (while we're at it) re-enable this field in the message info, as the main reason it was disabled was because we didn't know how to get the arrival timestamp in each case, which we will have to figure out for this:
Line 345 in 71b000c
// const rmw_time_t received_timestamp; |
Also, feel free to suggest a different name if you think arrival_timestamp
sounds better, or something similar.
Also, we should consider any changes to tests and documentation. One specific place I know is that we should mention this change in the release/migration notes for foxy:
In principle, I would test that a) allocation and deallocation works and b) that the fields are filled properly. However, it seems that a) happens in rcl and b) happens in the rmw implementation. So it doesn't appear as if I can test anything in rmw. Suggestions to the contrary very welcome, I want this to be solid :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating.
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Co-Authored-By: William Woodall <[email protected]> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Co-Authored-By: William Woodall <[email protected]> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Co-Authored-By: William Woodall <[email protected]> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Co-Authored-By: William Woodall <[email protected]> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Co-Authored-By: William Woodall <[email protected]> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Co-Authored-By: William Woodall <[email protected]> Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Closed in favor of #214 |
This goes together with ros2/rcl#591