Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qos configurability #635

Merged
merged 29 commits into from
Nov 17, 2020
Merged

Qos configurability #635

merged 29 commits into from
Nov 17, 2020

Commits on Oct 30, 2020

  1. Add QoSOverridingOptions 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    fdad6e3 View commit details
    Browse the repository at this point in the history

  2. Fix Node.get_parameters_by_prefix() type annotation 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    3300d10 View commit details
    Browse the repository at this point in the history

  3. Add helper classmethod for using default policies 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    67ac124 View commit details
    Browse the repository at this point in the history

  4. Add test cases 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    80781c9 View commit details
    Browse the repository at this point in the history

  5. Please linters + improve test setup and teardown 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    5fbc30c View commit details
    Browse the repository at this point in the history

  6. Declare qos overrides parameters in create_publisher/create_subscript… 

    …ion + fixes

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    5e6235b View commit details
    Browse the repository at this point in the history

  7. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    b18d0ba View commit details
    Browse the repository at this point in the history

  8. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    ef1e7bb View commit details
    Browse the repository at this point in the history

  9. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    fa434f9 View commit details
    Browse the repository at this point in the history

  10. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    2e5297f View commit details
    Browse the repository at this point in the history

  11. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    9b06ffa View commit details
    Browse the repository at this point in the history

  12. style 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    b34a04c View commit details
    Browse the repository at this point in the history

  13. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    51bddf4 View commit details
    Browse the repository at this point in the history

  14. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    fad4467 View commit details
    Browse the repository at this point in the history

  15. grammar 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    85a8cb7 View commit details
    Browse the repository at this point in the history

  16. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    589d2a2 View commit details
    Browse the repository at this point in the history

  17. bug 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    0c5e7ce View commit details
    Browse the repository at this point in the history

  18. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    17c834a View commit details
    Browse the repository at this point in the history

  19. Fix _get_qos_policy_parameter type annotation 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    50700ac View commit details
    Browse the repository at this point in the history

  20. qos -> QoS 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>

Co-authored-by: Jacob Perron <[email protected]>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    523dd59 View commit details
    Browse the repository at this point in the history

  21. _declare_qos_parameteres -> _declare_qos_parameters 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    812d44f View commit details
    Browse the repository at this point in the history

  22. Fix after rebasing 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    c4f109b View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Handle exception gracefully 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    751a601 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Suppress exception context 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    59951a3 View commit details
    Browse the repository at this point in the history

  2. flake8 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    9fce94b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Add test to CMakeLists 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    f8ba331 View commit details
    Browse the repository at this point in the history

  2. Use declare_or_get logic 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    0446d24 View commit details
    Browse the repository at this point in the history

  3. Improve testing 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    a9fc10f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. Add error message in validation callback result 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno
    ivanpauno committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    6b6f2c2 View commit details
    Browse the repository at this point in the history