use f-string to fix flake8 warning #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a flake8 error which would manifest as a KeyError at runtime when this exception is created. Signed-off-by: Steven! Ragnarök <[email protected]>
nuclearsandwich
force-pushed
the
fix-exception-format
branch
from
5c0a95a
to
59f594d
Compare
|
|
The CMake warning is from ament/ament_cmake#238 and is not related to this change. |
dirk-thomas
reviewed
Apr 10, 2020
Signed-off-by: Steven! Ragnarök <[email protected]>
dirk-thomas
approved these changes
Apr 10, 2020
|
Sanity rebuild on Linux alone |
dirk-thomas
changed the title
|
I updated the title and will go ahead and merge this since CI showed the flake8 warning is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a flake8 error which would manifest as a KeyError at runtime
when this exception is created.
Spotted in nightlies it took a minute to reproduce since the flake8 version we install claims to be incompatible with pyflakes 2.2.0 which was just released, which is likely why the error has the F999 code.