avoid copying Python files from source to build space #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm far from a CMake expert, but why is copying from the source to build space a bad practice? |
|
Oops, I just saw your comment on #2 (comment) |
|
I agree that having the installed code come directly from the source space is better. For the code in the build space used for running tests I think it is less important. The tests rely on both generated and compiled code so building before iterating on the test is already pretty common. We could have continued to use the file copy for the build space setup, and installed from the source space for a similar effect without the need for the complicated and somewhat confusing init file that mocks the source space. But since you've already implemented it we should probably keep it. +1 |
tfoote
added a commit
that referenced
this pull request
Feb 16, 2016
…ild_space avoid copying Python files from source to build space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #2 (comment)