Added support for services #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I imagine this requires synchronization with other branches on other repositories. |
| {} | ||
|
|
||
| std::shared_ptr<typename ServiceT::Response> | ||
| send_request(std::shared_ptr<typename ServiceT::Request> &req, long timeout=10) |
There was a problem hiding this comment.
Use std::chrono for the timeout.
|
I'll +1 one this pull request as well, with the same caveats as discussed in the other pull request: ros2/examples#3 (comment) |
Closed
alsora
pushed a commit
to alsora/rclcpp
that referenced
this pull request
Oct 12, 2020
rename functions in unit-tests
clalancette
added a commit
to clalancette/rclcpp
that referenced
this pull request
Dec 8, 2021
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <[email protected]> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <[email protected]> * More clarification of the types. Signed-off-by: Chris Lalancette <[email protected]> * More clarification of the types. Signed-off-by: Chris Lalancette <[email protected]> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
added a commit
to clalancette/rclcpp
that referenced
this pull request
Dec 21, 2021
* Rename the types so they are much more clear. Signed-off-by: Chris Lalancette <[email protected]> * More renaming of types in the subscription side. Signed-off-by: Chris Lalancette <[email protected]> * More clarification of the types. Signed-off-by: Chris Lalancette <[email protected]> * More clarification of the types. Signed-off-by: Chris Lalancette <[email protected]> * Cleanup subscription_intra_process_* classes. Remove virtual methods that are redundant (since they come from the underlying Waitable class), and mark methods as override as appropriate. Signed-off-by: Chris Lalancette <[email protected]>
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
fix for waitset api change
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* initial version of plugin based storage api * Add readable and writable storage interfaces * Fix build and uncrustify * Delete first storage interface proposal and adapt storage factory to new one * Modify test to work with new storage interfaces * Adapt sqlite3 plugin to new interface and extract rosbag2 part to own project * Adapt read() and write() methods signature * Prevent pluginlib from using boost * Add plugin development documentation * Remove Sqlite dependencies from rosbag2 tests * Add tests to rosbag2_storage_default_plugins * Add visibility control for Windows in rosbag_storage * Rename visibility_control.h to visibility_control.hpp * Cleanup CMakeLists in rosbag2_storage * Use void * instead of char * in rosbag_storage * Update plugin_description.xml and write() method * Introduce better logging using rcutils in rosbag_storage * Adapt interface and introduce better logging * Fix package.xml in rosbag2_storage * Add storage facade for plugins which are both readable and writable * Extract bag_info struct to own file * Change storage interface to have read/write access * Adapt copyright and use copyright linter * rosbag2 serialized message * remove colcon ignores * Add visibility to template specializations * Remove no longer necessary File install from CMakeLists.txt * Refactor storage_factory_impl.hpp * Minor refactoring * Add COLCON_IGNORE files to irrelevant projects * Fix Windows warning * Simpler class hierarchy without WritableStorage * Use exceptions instead of bool returns everywhere in interface * Change rosbag2_storage interface * storage interfaces * linters * a bit of refactoring * expose opening and closing * take messages as shared ptr * linters * rename to open, unique_ptr for pimpl * remove obsolete api * comply with new interfaces * change templated open to explicit open_ro and open_rw * Delete superfluous classes + polishing * Adapt SerializedBagMessage format * Let sqlite3 storage use new interface * Fix tests in rosbag2 * Write and read only data * Replace creation of shared instance by unmanaged instance * Add pragma for windows * Add visibility control for Windows * Expose template definitions * Move const to better location * Replace strcpy * Delete superfluous methods * Use visibility control in rosbag2 * Minor cleanup * test for nullptr when opening storage
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Display bag summary using `ros2 bag info` * Improve process execution helper to handle the working directory * Use metadata filename in sqlite storage to determine database name * ros2GH-109 Write metadata file on Windows by hand - On Windows, the process is killed hard and thus does not write its metadata file - Since this is an issue with the test setup that seems very hard to fix, for now we just write the metadata file on our own * Remove empty bag folder if record gets aborted and no files are created - For example is neither --all nor topics are specified or if a non exsisting storage plugin is specified * Fail gracefully if a runtime error occurs when trying to record or play - For example if the storage plugin specified by the user at record does not exist * Log error in case of failing when loading metadata, and minor refactoring * Add comment to version field * Allow rosbag2 info without yaml file Currently only supported on rosbag2 side: - Allow passing a storage identifier to rosbag2::Info() - If a yaml file exists, read info from yaml - If no yaml file exists and a storage identifier was passed open storage and read info directly * ros2GH-7 Don't try to read database name from metadata file when opening with ReadWrite io_flag - This avoids the logging of a 'failed to read metadata' error when recording a new bag * ros2GH-7 Rename 'storage format' into 'serialization format' -In this way it is not confused with the storage id (e.g. sqlite3) * ros2GH-7 Improve failure conditions * ros2GH-7 Cleanup of superfluous forward declarations * ros2GH-7 Further improve exception handling
ymski
added a commit
to ymski/rclcpp
that referenced
this pull request
Nov 21, 2023
…ric subscription (ros2#7) * added initialization tracepoint to generic_subscription Signed-off-by: yamasaki <[email protected]> * added callback_register Signed-off-by: yamasaki <[email protected]> * added callback_start/end Signed-off-by: yamasaki <[email protected]> * added subscription-side trace point Signed-off-by: ymski <[email protected]> * add rclcpp_publish to generic_publisher Signed-off-by: ymski <[email protected]> * removed unused dispatch_subscription_callback trace point Signed-off-by: ymski <[email protected]> * Update rclcpp/src/rclcpp/generic_subscription.cpp Co-authored-by: isp-uetsuki <[email protected]> * fix messege addr Signed-off-by: ymski <[email protected]> * remove redundant includes Signed-off-by: ymski <[email protected]> --------- Signed-off-by: yamasaki <[email protected]> Signed-off-by: ymski <[email protected]> Co-authored-by: isp-uetsuki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for clients and services in RCLCPP and integrates them with the executor infrastructure.