Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added services examples #3

Merged
merged 8 commits into from
Jan 17, 2015
Merged

Added services examples #3

merged 8 commits into from
Jan 17, 2015

Conversation

esteve
Copy link
Member

@esteve esteve commented Dec 18, 2014

This branch adds service and client examples.

dirk-thomas
dirk-thomas reviewed Jan 9, 2015
View reviewed changes
userland/src/add_two_ints_server.cpp
#include <userland_msgs/AddTwoInts.h>
#include <userland_msgs/RequestId.h>

void add(const std::shared_ptr<userland_msgs::AddTwoIntsRequest> req,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use userland_msgs::AddTwoInts::Request here.

@wjwwood
Copy link
Member

wjwwood commented Jan 15, 2015

+1 for me.

@esteve
Copy link
Member Author

esteve commented Jan 15, 2015

@wjwwood This branch depends on RTI's messaging library, which we haven't packaged and for which we don't have the source code, so this will break the current code unless we all install the messaging library. In any case, it'd be relatively straightfoward to reimplement that library on top of the existing classes or just implement the spec.

@wjwwood
Copy link
Member

wjwwood commented Jan 15, 2015

Ah, I forgot about needing to synchronize with the other packages.

I am +1'ing the current examples and rclcpp API. If we are blocked on the implementations for specific DDS vendors then in the mean time we can raise not implemented errors at compile time or run time. by doing this we can at least continue to iterate on the user facing API and the middleware API with your service changes in place.

Getting it working with RTI's public version and with OpenSplice is important, but we shouldn't let stalls there stop our work in trying to get our API's figured out.

@wjwwood wjwwood mentioned this pull request Jan 15, 2015
Merged
@esteve
Copy link
Member Author

esteve commented Jan 16, 2015

Ping @tfoote @dirk-thomas

@tfoote
Copy link
Contributor

tfoote commented Jan 16, 2015

+1 for the API

esteve added a commit that referenced this pull request Jan 17, 2015
@esteve
Merge pull request #3 from ros2/request_reply
6a35066 
Added services examples
@esteve esteve merged commit 6a35066 into master Jan 17, 2015
@esteve esteve deleted the request_reply branch January 17, 2015 00:34
@facontidavide facontidavide mentioned this pull request May 20, 2015
Closed
orduno added a commit to orduno/examples that referenced this pull request Jun 26, 2019
@orduno
# This is a combination of 3 commits.
13483b8 
# This is the 1st commit message:

Testing Minimal Client

# This is the commit message ros2#2:

Refactored, added multi-threaded test

# This is the commit message ros2#3:

Testing a custom executor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esteve @wjwwood @tfoote @dirk-thomas