use forward slashes instead of double underscores #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should those service names share a common definition somewhere? At least in a header, maybe even in an .msg file? |
|
Should the header file be visible to the outside and therefore be in the include folder instead? |
|
I don't think so, because in the end you'd call the ParameterClient/ParameterService to get the variants and don't want to actually call the service itself (IMO). |
|
waiting on CI:
|
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory prefix matching to be optional. Improving error messages around security directory lookup. Signed-off-by: Emerson Knapp <[email protected]> * Fixing get_best_matching_directory so that it always fetches the next file inside the loop. Signed-off-by: Emerson Knapp <[email protected]> * make pr ready for ros2cli security feature (#1) * update docs about possibility of rcl_take no taking (ros2#356) * update rcl_wait doc with respect to subs and possibility of failing takes * add a note about possible failing takes in rcl_take docs * 0.6.2 * Set rmw_wait timeout using ros timers too (ros2#357) * 0.6.3 * Avoid timer period being set to 0 (ros2#359) * Fix logic that moves goal handles when one expires (ros2#360) * Fix error from uncrustify v0.68 (ros2#364) * Ensure that context instance id storage is aligned correctly (ros2#365) * Ensure that context instance id storage is aligned correctly * Make alignment compatible with MSVC * Namespace alignment macro with RCL_ * [rcl] Guard against bad allocation calling rcl_arguments_copy() (ros2#367) * [rcl] Add test for copying arguments struct with no arguments * Override allocate function in test to reveal bug * [rcl] Only allocate arrays if there are things to copy in rcl_argument_copy() Also guard against freeing invalid pointers if rcl_argument_copy() fails. * Remove uncessary guard against NULL pointer * linter, styles, uncrustify fixes Signed-off-by: Emerson Knapp <[email protected]> * Update rcl/include/rcl/security_directory.h Co-Authored-By: AAlon <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> * Adding line break in docstring Signed-off-by: Emerson Knapp <[email protected]> * Removing duplicate doc string Signed-off-by: Emerson Knapp <[email protected]> * Removing tinydir from the source tree, instead using the ROS package tinydir_vendor. Signed-off-by: Emerson Knapp <[email protected]> * Removing tinydir Signed-off-by: Emerson Knapp <[email protected]> * Reformatting license notice as per linter template. Signed-off-by: Emerson Knapp <[email protected]> * Update test_security_directory.cpp Signed-off-by: Emerson Knapp <[email protected]> * Changing input to putenv to be a global, statically allocated buffer. Signed-off-by: Emerson Knapp <[email protected]> * test_security_directory - Using a larger buffer for env string manipulations. Signed-off-by: Emerson Knapp <[email protected]> * Copy environment variable to allocated string so it is not clobbered by next lookup Signed-off-by: Emerson Knapp <[email protected]> * Address review comments fix security directory exact match comment and unset env vars before tests Signed-off-by: Emerson Knapp <[email protected]> * Remove strncpy Signed-off-by: Emerson Knapp <[email protected]>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Adapt player publisher profile to recorded Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current parameter service and client implementation still use double underscores. I believe this has been forgotten to change when namespacing was introduced.
linux:
(test failures unrelated)
OSX:
Windows: