Time operator tests failing on Windows Debug #357
Assignees
Labels
Comments
|
This has been fixed in #362 |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this issue
Jul 9, 2022
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this issue
Jul 9, 2022
* Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory lookup to a prefix match rather than exact match. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests. Signed-off-by: Emerson Knapp <[email protected]> * Changing security directory prefix matching to be optional. Improving error messages around security directory lookup. Signed-off-by: Emerson Knapp <[email protected]> * Fixing get_best_matching_directory so that it always fetches the next file inside the loop. Signed-off-by: Emerson Knapp <[email protected]> * make pr ready for ros2cli security feature (#1) * update docs about possibility of rcl_take no taking (ros2#356) * update rcl_wait doc with respect to subs and possibility of failing takes * add a note about possible failing takes in rcl_take docs * 0.6.2 * Set rmw_wait timeout using ros timers too (ros2#357) * 0.6.3 * Avoid timer period being set to 0 (ros2#359) * Fix logic that moves goal handles when one expires (ros2#360) * Fix error from uncrustify v0.68 (ros2#364) * Ensure that context instance id storage is aligned correctly (ros2#365) * Ensure that context instance id storage is aligned correctly * Make alignment compatible with MSVC * Namespace alignment macro with RCL_ * [rcl] Guard against bad allocation calling rcl_arguments_copy() (ros2#367) * [rcl] Add test for copying arguments struct with no arguments * Override allocate function in test to reveal bug * [rcl] Only allocate arrays if there are things to copy in rcl_argument_copy() Also guard against freeing invalid pointers if rcl_argument_copy() fails. * Remove uncessary guard against NULL pointer * linter, styles, uncrustify fixes Signed-off-by: Emerson Knapp <[email protected]> * Update rcl/include/rcl/security_directory.h Co-Authored-By: AAlon <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> * Adding line break in docstring Signed-off-by: Emerson Knapp <[email protected]> * Removing duplicate doc string Signed-off-by: Emerson Knapp <[email protected]> * Removing tinydir from the source tree, instead using the ROS package tinydir_vendor. Signed-off-by: Emerson Knapp <[email protected]> * Removing tinydir Signed-off-by: Emerson Knapp <[email protected]> * Reformatting license notice as per linter template. Signed-off-by: Emerson Knapp <[email protected]> * Update test_security_directory.cpp Signed-off-by: Emerson Knapp <[email protected]> * Changing input to putenv to be a global, statically allocated buffer. Signed-off-by: Emerson Knapp <[email protected]> * test_security_directory - Using a larger buffer for env string manipulations. Signed-off-by: Emerson Knapp <[email protected]> * Copy environment variable to allocated string so it is not clobbered by next lookup Signed-off-by: Emerson Knapp <[email protected]> * Address review comments fix security directory exact match comment and unset env vars before tests Signed-off-by: Emerson Knapp <[email protected]> * Remove strncpy Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Operator tests introduced in #351 are failing on the windows debug nightly:
example ci: http://ci.ros2.org/view/nightly/job/nightly_win_deb/573/testReport/junit/(root)/TestTime/operators/
@Karsten1987 will look into it soon, ticketing it here in the meantime to leave a paper trail
The text was updated successfully, but these errors were encountered: