Added async_send_request_return_request to return the originating request #157
Conversation
|
I'm not sure about the name of the method, so I'd appreciate if anyone comes with a better one :-) |
|
@tfoote let me know if this is what you had in mind or if it needs to be reworked. |
|
That's what we talked about during the review. Is it not possible to overload the existing method which would avoid the very verbose method name? |
| @@ -142,10 +163,39 @@ class Client : public ClientBase | |||
| return f; | |||
| } | |||
|
|
|||
| SharedFutureWithRequest async_send_request_return_request(SharedRequest request) | |||
There was a problem hiding this comment.
Do we need this method? A noop callback doesn't need the request data.
esteve
force-pushed
the
return-request
branch
from
a5d2747
to
5c8d1a6
Compare
esteve
force-pushed
the
return-request
branch
from
5c8d1a6
to
35cf892
Compare
|
I ended up using New CI: http://ci.ros2.org/job/ros2_batch_ci_linux/606/ |
|
+1 The connext_dynamic job failed on the filename length. @wjwwood is that fix still pending? |
|
I pushed one last change to move the http://ci.ros2.org/job/ros2_batch_ci_linux/607/ |
esteve
added
in review
|
+1 the new name is much clearer. There probably will be usages in other repos of the old names? |
esteve
force-pushed
the
return-request
branch
from
b43fb5a
to
26d52d9
Compare
|
|
|
I also updated the code to pass uncrustify. |
Added async_send_request_return_request to return the originating request
* ros2GH-157 Adapt error messages of python code to C++ error format * ros2GH-157 Expose read ahead queue size property * ros2GH-157 Fixes for CTRL-C during playback - for large read-ahead-queue-size: Error message after closing - for small read-ahead-queue-size: CTRL-C doesn't interrupt * ros2GH-157 Clarify that -a or topics must be given * ros2GH-157 Get rid of --spin-time argument from record * ros2GH-157 Improve error output when info cannot read metadata * python touchups
Co-authored-by: Mauro Passerino <[email protected]>
Connects to #35