Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifecycle node class is missing parameter-related templates #642

Closed
mjeronimo opened this issue Feb 27, 2019 · 2 comments
Closed

Lifecycle node class is missing parameter-related templates #642

mjeronimo opened this issue Feb 27, 2019 · 2 comments
Assignees
@ivanpauno
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mjeronimo
Copy link
Contributor

Feature request

Feature description

The LifecycleNode class is missing several parameter-related templates that are present in the regular Node class, such as get_parameter_or, get_parameter_or_set, and set_parameter_if_not_set. Adding the missing templates would allow a lifecycle node to be equivalent to normal nodes in its parameter-handling functionality, making it easier to port from a Node to a LifecycleNode.

Implementation considerations

Should be able to copy/paste the templates from the Node header.
@Karsten1987 Karsten1987 added bug Something isn't working good first issue Good for newcomers labels Feb 27, 2019
@Karsten1987
Copy link
Contributor

thanks for reporting. The implementation considerations make sense to me given that the lifecycle node has a lot of function forwarding already.

@Karsten1987 Karsten1987 mentioned this issue Feb 27, 2019
Closed
@vinnamkim vinnamkim mentioned this issue Mar 4, 2019
Merged
@ivanpauno ivanpauno assigned ivanpauno and unassigned ivanpauno Mar 14, 2019
ivanpauno added a commit that referenced this issue Mar 14, 2019
@ivanpauno
Fixes #642
f15e0f9
@ivanpauno ivanpauno self-assigned this Mar 14, 2019
@ivanpauno ivanpauno added in progress Actively being worked on (Kanban column) and removed backlog labels Mar 14, 2019
ivanpauno added a commit that referenced this issue Mar 14, 2019
@ivanpauno
Fixes #642
81489f7 
Signed-off-by: ivanpauno <[email protected]>
@ivanpauno ivanpauno mentioned this issue Mar 14, 2019
Closed
@mjeronimo mjeronimo mentioned this issue Mar 14, 2019
Closed
@jacobperron
Copy link
Member

@Karsten1987 I think this has been resolved by #645. Please re-open if I'm mistaken.

@jacobperron jacobperron removed the in progress Actively being worked on (Kanban column) label May 9, 2019
@mjeronimo mjeronimo mentioned this issue Aug 9, 2019
Closed
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@iluetkeb
Initialize service timestamps to 0 and test. (ros2#642)
1eee2f2 
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mjcarroll @mjeronimo @jacobperron @Karsten1987 @ivanpauno