Add function to convert qos policy values to and from strings #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
jacobperron
reviewed
Oct 16, 2020
There was a problem hiding this comment.
Considering the functions operate only on RMW types, I'm inclined to say rmw is the best place for the implementation to live. No strong feelings about it though. @wjwwood Thoughts?
|
I don't have a strong opinion either, so I guess the small benefit of having them lower in the stack in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if the correct place would be here or in
rmw(moving the impl is easy), maybe some rmw implementations can take advantage of these functions.Required by ros2/rclcpp#1408, the idea is to avoid custom conversions in different clients (rclcpp, rclpy).