Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Set domain id to 0 if it is RMW_DEFAULT_DOMAIN_ID #719

Merged
merged 1 commit into from
Jul 20, 2020
Merged

[foxy] Set domain id to 0 if it is RMW_DEFAULT_DOMAIN_ID #719

merged 1 commit into from
Jul 20, 2020

Conversation

ivanpauno
Copy link
Member

Follow up of #694 (comment).
Backportable alternative to #718.

@ivanpauno ivanpauno added bug Something isn't working in review Waiting for review (Kanban column) labels Jul 17, 2020
@ivanpauno ivanpauno requested review from wjwwood and hidmic July 17, 2020 14:41
@ivanpauno ivanpauno self-assigned this Jul 17, 2020
hidmic
hidmic approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member Author

@jacobperron the failure in the PR checker seem to be unrelated, have you seen that failure in the past?

@jacobperron
Copy link
Member

the failure in the PR checker seem to be unrelated, have you seen that failure in the past?

The test_graph failure has happened before, but I haven't seen the test_subscription_nominal_string_sequence failure before. Maybe they are both flakes?

@jacobperron
Copy link
Member

@ros-pull-request-builder retest this please

jacobperron
jacobperron approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like those tests are flaky.

@ivanpauno ivanpauno merged commit fd5e56a into foxy Jul 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/foxy-actual-domain-id branch July 20, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@jacobperron jacobperron jacobperron approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivanpauno @jacobperron @wjwwood @hidmic