Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a generic way to change logging levels #664

Merged
merged 30 commits into from
Jul 8, 2020
Merged

Implement a generic way to change logging levels #664

merged 30 commits into from
Jul 8, 2020

Commits on Jul 8, 2020

  1. Implement a generic way to change logging levels 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    12cd013 View commit details
    Browse the repository at this point in the history

  2. Add comment and fix for some bad code style 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    87014ef View commit details
    Browse the repository at this point in the history

  3. Add more check and test cases. 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    896037d View commit details
    Browse the repository at this point in the history

  4. Update test code with c++ style and remove unnecessary code 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    00b2b62 View commit details
    Browse the repository at this point in the history

  5. Get rid of test fixture. 

    We don't need to test this per-RMW, so just get rid of
the test fixture completely.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4d28958 View commit details
    Browse the repository at this point in the history

  6. Replace macro with function. 

    It is just easier to maintain that way.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7c5e458 View commit details
    Browse the repository at this point in the history

  7. seperator -> separator 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e2ecd3e View commit details
    Browse the repository at this point in the history

  8. Make sure to deallocate item on all error paths. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    3d77ef4 View commit details
    Browse the repository at this point in the history

  9. Make sure to deallocate logger_log_level->name on error. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f7f60ff View commit details
    Browse the repository at this point in the history

  10. Make sure to deallocate value on all error paths. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    352b12d View commit details
    Browse the repository at this point in the history

  11. Make sure to call rcutils_logging_shutdown(). 

    This ensures we don't have a memory leak from the rcutils
logging subsystem at the end of the test run.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    bd2413f View commit details
    Browse the repository at this point in the history

  12. Use := as separator and remove multiple logger settings in one argument 

    Signed-off-by: Chen Lihui <[email protected]>
Co-authored-by: Tomoya.Fujita <[email protected]>
Co-authored-by: Ivan Santiago Paunovic <[email protected]>
    @fujitatomoya @ivanpauno @clalancette
    3 people authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    141aa0b View commit details
    Browse the repository at this point in the history

  13. Update for some comments 

    1. use rcl_log_levels_t
2. update function interfaces
3. use argc as logger count instead of a fixed number

Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    bee60a2 View commit details
    Browse the repository at this point in the history

  14. Remove empty newline 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    eb6138d View commit details
    Browse the repository at this point in the history

  15. Remove a redundant check 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0e3a42a View commit details
    Browse the repository at this point in the history

  16. Add in some more error checks. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    79d36aa View commit details
    Browse the repository at this point in the history

  17. update for comments 

    1. use lexer to parse log-level
2. add shrink function

Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    07ef7fd View commit details
    Browse the repository at this point in the history

  18. Update for testing the command-line precedence order with two same lo… 

    …gger name

Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    ce94ba0 View commit details
    Browse the repository at this point in the history

  19. Update for removing init before copy 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    95c4a21 View commit details
    Browse the repository at this point in the history

  20. Fixed for uncrustify checking 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a2b87f5 View commit details
    Browse the repository at this point in the history

  21. Use rcl_reset_error instead of rcutils_reset_error. 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b4393a4 View commit details
    Browse the repository at this point in the history

  22. Update for review comments 

    Signed-off-by: Chen Lihui <[email protected]>
Co-authored-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno @clalancette
    2 people authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    66113e0 View commit details
    Browse the repository at this point in the history

  23. Use stack variable instead of pointer for log levels in arguments 

    Signed-off-by: Chen Lihui <[email protected]>
Co-authored-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno @clalancette
    2 people authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    abbac3c View commit details
    Browse the repository at this point in the history

  24. Adjust setting log level value 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    dc5c2b8 View commit details
    Browse the repository at this point in the history

  25. Fixed for uncrustify checking 

    Signed-off-by: Chen Lihui <[email protected]>
    @clalancette
    Chen Lihui authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    3ec0c30 View commit details
    Browse the repository at this point in the history

  26. Avoid memory leak 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0d1d799 View commit details
    Browse the repository at this point in the history

  27. Dont use static 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    165fff5 View commit details
    Browse the repository at this point in the history

  28. Make finishing zero initialized log levels structure safe 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7ebf60c View commit details
    Browse the repository at this point in the history

  29. Clarify API contract 

    Signed-off-by: Ivan Santiago Paunovic <[email protected]>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b600a43 View commit details
    Browse the repository at this point in the history

  30. Completely initialize allocator for clang-tidy. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9ee1d9a View commit details
    Browse the repository at this point in the history