Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #384 for Crystal. #385

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Backport #384 for Crystal. #385

merged 1 commit into from
Feb 8, 2019

Conversation

nuclearsandwich
Copy link
Member

Backport of #384 to resolve error on the current Crystal devel branch.

@ross-desmond @nuclearsandwich
Change error to warning for multiple loggers. (#384)
c872c81 
* Change error to warning for multiple loggers

* Updating warning message

* Updating TODO message.

* Reformatting todo and uncrustify warn message.

* Add early return back in.

* Break string literal across multiple lines.

Signed-off-by: Steven! Ragnarök <[email protected]>

* Remove commented-out error and return block.

Signed-off-by: Steven! Ragnarök <[email protected]>
@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Feb 7, 2019
@nuclearsandwich nuclearsandwich self-assigned this Feb 7, 2019
@nuclearsandwich
Copy link
Member Author

Trying an overlay build Build Status

@chapulina
Copy link

/tmp/ws_overlay/src/ros2/rcl/rcl/src/rcl/logging_rosout.c:26:10: fatal error: rcutils/types/hash_map.h: No such file or directory

I think you'll need ros2/rcutils#131

@chapulina
Copy link

New CI with custom repos file that pulls rcutils from master: Build Status

@nuclearsandwich nuclearsandwich merged commit 8b3a4a0 into crystal Feb 8, 2019
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Feb 8, 2019
@nuclearsandwich nuclearsandwich deleted the backport-384 branch February 8, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@jacobperron jacobperron jacobperron approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nuclearsandwich @chapulina @jacobperron @ross-desmond