Increase the test_action_interaction timeouts. #1172
Conversation
While I can't reproduce the problem locally, I suspect that waiting only 1 second for the entities to become ready isn't enough in all cases, particularly on Windows, with Connext, and when we are running in parallel with other tests. Thus, increase the timeout for the rcl_wait() in all of the test_action_interaction tests, which should hopefully be enough to make this always pass. Signed-off-by: Chris Lalancette <[email protected]>
|
Here's CI with this in place, intentionally running everything to ensure that
|
There was a problem hiding this comment.
@clalancette i am okay to extend the wait duration. one question is that can we verify this PR can actually mitigate the #1162 with nightly build before merging this?
Not really, unfortunately. The best we can do is to run the full set of tests to try to reproduce the conditions in which it fails. I think only merging it and keeping an eye on the flakiness over time will really tell us whether this is enough or not. |
While I can't reproduce the problem locally, I suspect that waiting only 1 second for the entities to become ready isn't enough in all cases, particularly on Windows, with Connext, and when we are running in parallel with other tests. Thus, increase the timeout for the rcl_wait() in all of the test_action_interaction tests, which should hopefully be enough to make this always pass.
In theory this should fix #1162