Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test_count_matched test to handle non-DDS RMWs #1164

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Cleanup test_count_matched test to handle non-DDS RMWs #1164

merged 5 commits into from
Jul 1, 2024

Commits on Jun 27, 2024

  1. Make check_state a class method in test_count_matched. 

    This allows us to pass fewer parameters into each
each invocation, and allows us to hide some more of
the implementation inside the class.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    02ea807 View commit details
    Browse the repository at this point in the history

  2. Rename "ops" to "opts" in test_count_matched. 

    It just better reflects what these structures are.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a0f5e0f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Cleanup pub/subs with a scope_exit in test_count_matched. 

    This just ensures that they are always cleaned up, even
if we exit early.  Note that we specifically do *not*
use it for test_count_matched_functions, since the cleanup
is intentionally interleaved with other tests.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ab98403 View commit details
    Browse the repository at this point in the history

  2. Check with the RMW layer to see whether QoS is compatible. 

    Some RMWs may have different compatibility than DDS, so
check with the RMW layer to see what we should expect for
the number of publishers and subscriptions.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ab02c1a View commit details
    Browse the repository at this point in the history

  3. Fixes from review. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8d468ca View commit details
    Browse the repository at this point in the history