Improve handling of discovery - RCL changes. Extends #1023 #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjo129
added a commit
to arjo129/rmw_fastrtps
that referenced
this pull request
Mar 2, 2023
See: * ros2/rmw#349 * ros2/rcl#1038 Signed-off-by: Arjo Chakravarty <[email protected]>
wjwwood
changed the base branch from
rolling
to
gbiggs/discovery-peers-specification
wjwwood
force-pushed
the
gbiggs/discovery-peers-specification
branch
from
731106f
to
4529112
Compare
Signed-off-by: Michael X. Grey <[email protected]>
This commit adds support for dynamic allocation for unlimited number of static peers. Signed-off-by: Arjo Chakravarty <[email protected]>
set. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
wjwwood
force-pushed
the
arjo/dynamic_alloc
branch
from
9b0d955
to
a7ca84d
Compare
|
Merging into #1023 |
wjwwood
pushed a commit
to arjo129/rmw_fastrtps
that referenced
this pull request
Mar 21, 2023
See: * ros2/rmw#349 * ros2/rcl#1038 Signed-off-by: Arjo Chakravarty <[email protected]>
wjwwood
pushed a commit
to ros2/rmw_fastrtps
that referenced
this pull request
Mar 21, 2023
See: * ros2/rmw#349 * ros2/rcl#1038 Signed-off-by: Arjo Chakravarty <[email protected]>
sloretz
added a commit
to ros2/rmw_fastrtps
that referenced
this pull request
Apr 8, 2023
* Support specification of discovery range and static peers Signed-off-by: Geoffrey Biggs <[email protected]> * Apply suggestions from eProsima Signed-off-by: Geoffrey Biggs <[email protected]> * Use participant ignoring Signed-off-by: Geoffrey Biggs <[email protected]> * Improve handling of aliases for hosts Signed-off-by: Geoffrey Biggs <[email protected]> * Adds support for using IP addresses to specify peers This commit adds support for using IP addresses to specify peers. It also refactors out some networking function so that they can be used by other files. Signed-off-by: Arjo Chakravarty <[email protected]> * Remove excessive logging Signed-off-by: Arjo Chakravarty <[email protected]> * Add name lookup and clean up implementation. Signed-off-by: Arjo Chakravarty <[email protected]> * Two more scenarios fixed. Two more to go. Signed-off-by: Arjo Chakravarty <[email protected]> * Revert rmw changes Signed-off-by: Arjo Chakravarty <[email protected]> * Add support for dynamic allocations See: * ros2/rmw#349 * ros2/rcl#1038 Signed-off-by: Arjo Chakravarty <[email protected]> * Support new requirements Signed-off-by: Arjo Chakravarty <[email protected]> * Update to latest rmw API Signed-off-by: Michael X. Grey <[email protected]> * Update to use API on Fast-DDS master Signed-off-by: Shane Loretz <[email protected]> * Update with rmw_discovery_options_t changes Signed-off-by: Shane Loretz <[email protected]> * Minimize diff with rolling in custom_participant_info.hpp Signed-off-by: Shane Loretz <[email protected]> * Minimize diff with rolling in participant.cpp Signed-off-by: Shane Loretz <[email protected]> * Collapse lines Signed-off-by: Shane Loretz <[email protected]> * conditional on one line Signed-off-by: Shane Loretz <[email protected]> * return instead of setting variable Signed-off-by: Shane Loretz <[email protected]> * Make log messages more informative Signed-off-by: Shane Loretz <[email protected]> * Works without ignore participant change! Signed-off-by: Shane Loretz <[email protected]> * Remove unused code Signed-off-by: Shane Loretz <[email protected]> * Remove more unused code Signed-off-by: Shane Loretz <[email protected]> * Minimize diff with rolling Signed-off-by: Shane Loretz <[email protected]> * NOT_SET and SYSTEM_DEFAULT values Signed-off-by: Shane Loretz <[email protected]> * OFF implementation that doesn't crash Signed-off-by: Shane Loretz <[email protected]> * Set discovery range in test Signed-off-by: Shane Loretz <[email protected]> * Lint Signed-off-by: Shane Loretz <[email protected]> * Call rmw_discovery_options_init() Signed-off-by: Shane Loretz <[email protected]> * Workaround deadlock with rclcpp global logging mutex Signed-off-by: Shane Loretz <[email protected]> * Add shared memory transport for LOCALHOST traffic Signed-off-by: Shane Loretz <[email protected]> * Configure max initial peers range on udp transport Signed-off-by: Shane Loretz <[email protected]> * Disable built-in transports and fix lint Signed-off-by: Shane Loretz <[email protected]> * Error when range is an invalid value Signed-off-by: Shane Loretz <[email protected]> * undo unnecessary test change Signed-off-by: Shane Loretz <[email protected]> * Document Setting range to SYSTEM_DEFAULT Signed-off-by: Shane Loretz <[email protected]> * Limit participants to 1 when discover is OFF Signed-off-by: Shane Loretz <[email protected]> * With SUBNET and initial peers, add default multicast address as a multicast locator Signed-off-by: Shane Loretz <[email protected]> * Add multicast address to initial peer list when there are other static peers and SUBNET range Signed-off-by: Shane Loretz <[email protected]> * Bump required Fast-DDS version to 2.10 Signed-off-by: Shane Loretz <[email protected]> * Set maxInitialPeersRange to 32 Signed-off-by: Shane Loretz <[email protected]> * Grammar Signed-off-by: Shane Loretz <[email protected]> * Shorten sentence Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Geoffrey Biggs <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]> Co-authored-by: Michael X. Grey <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dynamic allocation
Depends on: