Skip to content

Commit

Permalink
Support passing yaml parameter files via commandline (#253)
Browse files Browse the repository at this point in the history
* wip

* rcl_arguments_get_param_files() with char **

Restore version of function that outputs a char **

* _rcl_parse_param_rule() allocates string

Before this commit `rcl_parse_params` was allocating space the size of
the argument, but the space only needs to be as big as the argument
minus the prefix length.

* Debug print before incrementing num files

* Alloc and make sure to dealloc on failure

* fix print of parsed parameter rule

* rcutils types not needed as we dont use rcutils_string_array anymore

* minimal test

* cleanup debug prints

* linter fixup

* add tests for param arguments

* lint tests

* Doc for rcl_arguments_get_param_files_count()

* Shrink parameter files

* const param_prefix_len

* Copy parameter file names

* deallocate parameter files in fini

* free memory after tests pass
  • Loading branch information
mikaelarguedas authored and Karsten1987 committed Jun 13, 2018
1 parent 619a3de commit ebe27f1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions rcl/include/rcl/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,4 @@ typedef rmw_ret_t rcl_ret_t;
/// Argument is not a valid log level rule
#define RCL_RET_INVALID_LOG_LEVEL_RULE 1020

/// typedef for rmw_message_raw_t;
typedef rmw_message_raw_t rcl_message_raw_t;

#endif // RCL__TYPES_H_

0 comments on commit ebe27f1

Please sign in to comment.