-
Notifications
You must be signed in to change notification settings - Fork 7
Enable forcing build from source, and pass through c++ flags #24
Conversation
Signed-off-by: Emerson Knapp <[email protected]>
@thomas-moulard https://gist.githubusercontent.com/emersonknapp/4aad1eaadcec008d8e4037362b8620b9/raw/584f088d7bbc8390744ae7e378c958d19eed127b/ros2.repos This should cover everything for a CI build. We should probably specify |
This comment has been minimized.
This comment has been minimized.
Pushed new commit on this and other vendor pkgs, plus the colcon mixin |
This is a full build and partial test that I originally intended to test that things are good when building forcing the vendor builds but because I messed up the option name now it's testing that this doesn't regress the default case of only building when the package isn't found. Covers all the #ros2/ros2#664 vendor packages. Edit: re-triggered with an updated gist for rclcpp_action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged once green CI comes back for both the standard configuration and with FORCE_BUILD_VENDOR_PKG=ON 🥗
@emersonknapp that last CI right might actually be overzealousness on my part. Is the libcxx stuff even expected to be functional on Mac and Win as is? |
My understanding is that we were not targeting Windows or OSX for the clang-libcxx build yet. Looking into the OSX failure for rviz |
Can we disable tests for this build for now? Or, start it out as being unstable because of failed tests? I think we've made a significant milestone in compiling end to end with libcxx |
Based on the failing tests, it doesn't seem like class_loader, and therefore pluginlib is functional with the libcxx changes. As long as those aren't needed by what you plan to test then we can avoid running class loader tests. |
The first goal is to test compilation - in order to get thread safety compile-time warnings. I think we can work towards making all the tests pass - it would be great to get it going as a nightly that we can start working on fixes for. |
Utilize the variable names proposed in the libcxx colcon mixin colcon/colcon-mixin-repository#16 to be able to force
Related to ros2/ros2#664