-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mixin to force clang and libcxx #16
Conversation
Could you elaborate when this global flags is necessary? compared to e.g. using CXXFLAGS? |
@thomas-moulard here is an example that uses both flags ros2/poco_vendor#24 |
Signed-off-by: Emerson Knapp <[email protected]>
I was able to "force libcxx" down the line by using full passthrough of CMAKE_CXX_FLAGS, as per @dirk-thomas suggestion. This seems to have worked for all downstream packages. As for |
With this mixin, plus a few other minor pull requests that are incoming,
|
@emersonknapp are you planning to switch our existing linux-clang job to use libcxx or add an additional job? |
The way I see it, there is value in having CI builds for both:
|
Edited up to date summary:
This mixin would be used on Clang CI build to enable Thread Safety Analysis, and generally validate that ROS2 works with libcxx
Related to:
Connects to ros2/ros2#664