Create new messages with all fields needed to define a velocity and transform it #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transform it Signed-off-by: Dr. Denis <[email protected]>
Signed-off-by: Dr. Denis <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
…tamped-msg Suggestions to VelocityStamped
tfoote
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Thanks for pulling this all together @ahcorde I think that this gets us to a moderately compact message which I think has clear semantics.
Is ros2/geometry2#646 up to date with this?
|
@destogl @SteveMacenski @azeey Can you take a look at this updated version of #233 ? It would be really valuable to get this finalized this week. |
azeey
reviewed
Apr 2, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Update geometry_msgs/msg/VelocityStamped.msg Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Update geometry_msgs/msg/VelocityStamped.msg Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
force-pushed
the
ahcorde/add-velocity-stamped-msg
branch
from
467a6ec
to
021097c
Compare
@tfoote, yes, it's up to date |
tfoote
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
With a test implementation available in ros2/geometry2#646
And running CI against the union of these two:
- Linux
- Linux-aarch64
- Windows
This now looks ready to go.
|
warnings are in the other PR, merging this one |
tfoote
added a commit
that referenced
this pull request
Apr 10, 2024
…ransform it (#240) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Tully Foote <[email protected]>
This was referenced Apr 29, 2024
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2024
…ransform it (#240) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Tully Foote <[email protected]> (cherry picked from commit 74137fc)
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2024
…ransform it (#240) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Tully Foote <[email protected]> (cherry picked from commit 74137fc)
|
There is a request to backport this feature in geometry2. This is a new message, it's fine to backport this to |
ahcorde
added a commit
that referenced
this pull request
May 20, 2024
…ransform it (#240) (#249) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Tully Foote <[email protected]> (cherry picked from commit 74137fc) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
May 20, 2024
…ransform it (#240) (#250) Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Tully Foote <[email protected]> (cherry picked from commit 74137fc) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @destogl,
I superseed this other PR #233 We want to merge this in before feature freeze which I believe it's in two weeks.