Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update distribution.yaml #36408

Merged
merged 4 commits into from
May 16, 2023
Merged

Update distribution.yaml #36408

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff09923
Update distribution.yaml
pabloinigoblasco Mar 7, 2023
61fb018
Update distribution.yaml
pabloinigoblasco Mar 12, 2023
6ca2f5e
Update distribution.yaml
pabloinigoblasco Mar 12, 2023
17d32c8
Update distribution.yaml
pabloinigoblasco Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions humble/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,6 @@ release_platforms:
ubuntu:
- jammy
repositories:
SMACC2:
doc:
type: git
url: https://github.com/robosoft-ai/SMACC2.git
version: master
release:
packages:
- smacc2
- smacc2_msgs
tags:
release: release/humble/{package}/{version}
url: https://github.com/ros2-gbp/SMACC2-release.git
version: 0.4.0-2
source:
type: git
url: https://github.com/robosoft-ai/SMACC2.git
version: master
status: developed
acado_vendor:
release:
tags:
Expand Down Expand Up @@ -6299,6 +6281,24 @@ repositories:
url: https://github.com/oKermorgant/slider_publisher.git
version: ros2
status: maintained
smacc2:
doc:
type: git
url: https://github.com/robosoft-ai/SMACC2.git
version: humble
release:
packages:
- smacc2
- smacc2_msgs
tags:
release: release/humble/{package}/{version}
url: https://github.com/ros2-gbp/SMACC2-release.git
version: 2.3.5-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version tag isn't available in the release repository https://github.com/ros2-gbp/SMACC2-release, CI won't pass until it is correctly bloomed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already updated the SMACC2-release repo with new versions. Think this is now fixed.

now I am getting the following error, what does that mean? It looks like it misses the package smacc2

FAILED test/test_build_caches.py::test_build_caches - RuntimeError: humble: missing package.xml file for package "smacc2"
humble: missing package.xml file for package "smacc2_msgs"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that the version tag for smacc2_msgs is also not found. It should follow the format described above, so release/humble/smacc2_msgs/2.3.5-1

I'm not seeing any tags in the smacc2-release repo that include the 2.3.5 version.

Are you using bloom to release this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the versions correctly in the release repo:

https://github.com/robosoft-ai/SMACC2-release/tree/release/humble/smacc2_msgs/2.3.5-1
https://github.com/robosoft-ai/SMACC2-release/tree/release/humble/smacc2/2.3.5-1

Yes I am using bloom but it fails in the final PR step because I am getting problems due to SMACC2 is uppercase in the rosdistro.yaml file.

My main goal is to fix that in order to enable the usage of bloom normally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the url field to reflect the new release location. The release repo is currently here based on the rosdistro file: https://github.com/ros2-gbp/SMACC2-release.git

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already working

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is in a lot better condition now. Can you just update the description in the pull request body to match what this is doing? I think you may have kept some of the other template sections in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this update on the template be enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette could we move forward on this?

source:
type: git
url: https://github.com/robosoft-ai/SMACC2.git
version: humble
status: developed
snowbot_operating_system:
doc:
type: git
Expand Down