ros2: Start porting #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add standard bits - Upgrade `visualization_marker_tutorials` - Add `COLCON_IGNORE` for packages not yet ported
|
@wjwwood Can I ask for your review, and what to do about some of these checkboxes? |
This was referenced Apr 6, 2019
Closed
|
I created Keep BSD. The rviz config files are dumps from rviz, so no I don't think you can remove anything from them. |
wjwwood
reviewed
Apr 16, 2019
| @@ -2,6 +2,10 @@ | |||
| Changelog for package visualization_marker_tutorials | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| 0.11.0 (2019-04-05) | |||
There was a problem hiding this comment.
This version won't work, as it prevents us from continuing to progress on the ROS 1 branch.
Also, this is not how releases work... Please just have here the porting changes, once that's merged we can look at a release, documented here: https://index.ros.org/doc/ros2/Tutorials/Releasing-a-ROS-2-package-with-bloom/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visualization_marker_tutorialsCOLCON_IGNOREfor packages not yet portedSTATUS: Not ready to merge (beyond review). To resolve:
crystal-develor whatever branch here?This change is