Changed the build type to ament_python and added setup.cfg #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
jacobperron
reviewed
May 13, 2020
Signed-off-by: ahcorde <[email protected]>
jacobperron
reviewed
May 14, 2020
There was a problem hiding this comment.
I can't get the executable to run. I think there's something wrong with the setup.py.
$ ros2 run rqt_console rqt_console
RosPluginProvider.load(rqt_console/Console) exception raised in __builtin__.__import__(rqt_console.console, [Console]):
Traceback (most recent call last):
File "/opt/ros/foxy/lib/python3.8/site-packages/rqt_gui/ros_plugin_provider.py", line 80, in load
module = __builtin__.__import__(
File "/root/rqt_console_ws/install/rqt_console/lib/python3.8/site-packages/rqt_console/console.py", line 43, in <module>
from rqt_console.console_widget import ConsoleWidget
File "/root/rqt_console_ws/install/rqt_console/lib/python3.8/site-packages/rqt_console/console_widget.py", line 48, in <module>
from .filters.custom_filter import CustomFilter
ModuleNotFoundError: No module named 'rqt_console.filters'
PluginManager._load_plugin() could not load plugin "rqt_console/Console":
Traceback (most recent call last):
File "/opt/ros/foxy/lib/python3.8/site-packages/qt_gui/plugin_handler.py", line 102, in load
self._load()
File "/opt/ros/foxy/lib/python3.8/site-packages/qt_gui/plugin_handler_direct.py", line 55, in _load
self._plugin = self._plugin_provider.load(self._instance_id.plugin_id, self._context)
File "/opt/ros/foxy/lib/python3.8/site-packages/qt_gui/composite_plugin_provider.py", line 72, in load
instance = plugin_provider.load(plugin_id, plugin_context)
File "/opt/ros/foxy/lib/python3.8/site-packages/qt_gui/composite_plugin_provider.py", line 72, in load
instance = plugin_provider.load(plugin_id, plugin_context)
File "/opt/ros/foxy/lib/python3.8/site-packages/rqt_gui_py/ros_py_plugin_provider.py", line 64, in load
return super(RosPyPluginProvider, self).load(plugin_id, ros_plugin_context)
File "/opt/ros/foxy/lib/python3.8/site-packages/qt_gui/composite_plugin_provider.py", line 72, in load
instance = plugin_provider.load(plugin_id, plugin_context)
File "/opt/ros/foxy/lib/python3.8/site-packages/rqt_gui/ros_plugin_provider.py", line 91, in load
raise e
File "/opt/ros/foxy/lib/python3.8/site-packages/rqt_gui/ros_plugin_provider.py", line 80, in load
module = __builtin__.__import__(
File "/root/rqt_console_ws/install/rqt_console/lib/python3.8/site-packages/rqt_console/console.py", line 43, in <module>
from rqt_console.console_widget import ConsoleWidget
File "/root/rqt_console_ws/install/rqt_console/lib/python3.8/site-packages/rqt_console/console_widget.py", line 48, in <module>
from .filters.custom_filter import CustomFilter
ModuleNotFoundError: No module named 'rqt_console.filters'
It might make sense to move the source files out of the src directory, similar to other ROS 2 python packages.
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
ahcorde
changed the title
jacobperron
approved these changes
May 26, 2020
There was a problem hiding this comment.
LGTM pending CI
I do see this error when I stop (ctrl-c) the process, but seems like something unrelated to this change (ros-visualization/qt_gui_core#213).
|
@jacobperron This package does not have any tests. Does make sense to include copyright, flake8 and pep256? I can do it in a follow up PR. Running CI up-to rqt_console
|
If you like, a follow-up PR sounds good. |
|
can we merge this? |
ahcorde
changed the title
|
@jacobperron CI is green, can we merge this one?
|
dirk-thomas
reviewed
Jul 27, 2020
Signed-off-by: ahcorde <[email protected]>
ivanpauno
approved these changes
Nov 30, 2020
ivanpauno
reviewed
Nov 30, 2020
Signed-off-by: ahcorde <[email protected]>
ivanpauno
approved these changes
Jan 26, 2021
|
ahcorde
added a commit
that referenced
this pull request
Jan 27, 2021
Signed-off-by: ahcorde <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jan 27, 2021
Signed-off-by: ahcorde <[email protected]>
Closed
arne48
pushed a commit
that referenced
this pull request
Jul 15, 2022
* Fixed package to run with ros2 run Signed-off-by: ahcorde <[email protected]> * Fix author and maintener Signed-off-by: ahcorde <[email protected]> * Fixed version on setup.py Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * Fixed description Signed-off-by: ahcorde <[email protected]> * package collected automatically using setuptools.find_packages() Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]>
arne48
pushed a commit
that referenced
this pull request
Jul 15, 2022
Signed-off-by: ahcorde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed package to run with
ros2 run rqt_console rqt_console. Related to this issue #20Signed-off-by: ahcorde [email protected]