Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requesting foxy release #38

Closed
tfoote opened this issue Jul 14, 2022 · 3 comments
Closed

requesting foxy release #38

tfoote opened this issue Jul 14, 2022 · 3 comments
Assignees

Comments

@tfoote
Copy link

tfoote commented Jul 14, 2022

The last release in foxy is 1.1.1

PRs #21 and #28 were landed into the foxy branch after that but there has not been a release which includes the solutions which are in foxy-devel.

Note that in the index foxy is indexed to dashing-devel

@arne48 arne48 self-assigned this Jul 15, 2022
@arne48
Copy link
Member

arne48 commented Jul 15, 2022

I am currently trying to figure out the best approach to get an updated release 2.0.2 for foxy.
Because the foxy-devel branch was reverted to version 1.1.1 after it was branched off of 2.0.0
Currently, I think one way could be to reset the foxy-devel branch to 2.0.0 and then rebase or fast-forward to the humble branch, aka 2.0.2
But my gut feeling for using reset is pretty bad.
Another more practical way could be changing the devel_branch in the gbp repository for foxy to humble and get the 2.0.2 version that way.
Afterward, we could just wait out the time until next year when foxy enters its EOL.
I already tested the current humble branch in foxy, and it works, so for this release, this could be a non-intrusive solution.

Which one would you @tfoote prefer?

But maybe I also oversee the obvious in that case; I would also be very thankful for a hint :)

@tfoote
Copy link
Author

tfoote commented Jul 15, 2022

We don't need to push that far forward. It would be fine to just cut a 1.1.2 release with the patches staged on the foxy-devel branch already. The specific fix has been backported directly. The fixes are in f174bd9 and 9442cc8

Since the 2.0.0 number change was only in the source and not released into foxy, it being reverted isn't a problem.

It does look like the changes in the humble branch would be fine to release into foxy. But I'd suggest for now doing the simplest solution of just going to 1.1.2 on the foxy branch. It looks like the source branch should be updated to foxy-devel in the rosdistro and release repository from the previously unforked dashing-devel but otherwise it's just a patch release.

@arne48
Copy link
Member

arne48 commented Jul 15, 2022

Cherry-picking is actually another good idea I just wasn't sure about 1.x version tree.
Thank you very much for clarifying this; I now cherry-picked #21 and #28.
During testing, I noticed the bug that was fixed with #37 and cherry-picked that commit as well.
Compared to version 2.0.2, this version now seems to be only short of #31, but this should be fine as here ros2/ros2cli#627, it is discussed that this would break on focal.
I also bloomed the new version already.
Thank you very much for your help @tfoote :)

I hope closing this issue would be therefore fine now.

@arne48 arne48 closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants