Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Noble for Rolling. (#193) #196

Merged
merged 3 commits into from
May 23, 2024
Merged

Switch to Noble for Rolling. (#193) #196

merged 3 commits into from
May 23, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 18, 2024

@clalancette @wep21
Switch to Noble for Rolling. (ros-tooling#193)
0bc5ce4 
* Switch to Noble for Rolling.

* Updates for the latest action-ros-ci.

Signed-off-by: Chris Lalancette <[email protected]>
@wep21 wep21 requested a review from a team as a code owner May 18, 2024 06:43
@wep21 wep21 requested review from emersonknapp and MichaelOrlov and removed request for a team May 18, 2024 06:43
@codecov Codecov
Copy link

codecov bot commented May 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (jazzy@3c3bd03). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff            @@
##             jazzy     #196   +/-   ##
========================================
  Coverage         ?   24.35%           
========================================
  Files            ?       67           
  Lines            ?     5382           
  Branches         ?      663           
========================================
  Hits             ?     1311           
  Misses           ?     3976           
  Partials         ?       95
Flag Coverage Δ
unittests 24.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christophebedard
Copy link
Member

I would also just wait until the jazzy branch freeze is over until merging this.

christophebedard
christophebedard approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, the freeze has been lifted, and this only modifies local GitHub CI, so no need to run ROS 2 CI. Thanks for the PR.

christophebedard
christophebedard requested changes May 23, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change rolling to jazzy in a couple places.

wep21
wep21 commented May 23, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
wep21
wep21 commented May 23, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@wep21 wep21 requested a review from christophebedard May 23, 2024 17:27
@christophebedard christophebedard merged commit 94ad02b into ros-tooling:jazzy May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros-tooling/reviewers

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros-tooling/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wep21 @christophebedard @clalancette