Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency on nav2_costmap_2d #4742

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Nov 6, 2024


Basic Info

Info Please fill out this column
Primary OS tested on Ubuntu 24

Description of contribution in a few bullet points

  • Fix missing dependencies found when refactoring nav2_core to remove the dependency on nav2_costmap_2d. Without this, nav2_controller would fail to build because it didn't know about the nav2_costmap_2d::nav2_costmap_2d_core target
--- stderr: nav2_controller                                                                                                                                                                
CMake Error at CMakeLists.txt:35 (target_link_libraries):
  Target "controller_server_core" links to:

    nav2_costmap_2d::nav2_costmap_2d_core

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.



CMake Error at CMakeLists.txt:113 (target_link_libraries):
  Target "simple_goal_checker" links to:

    nav2_costmap_2d::nav2_costmap_2d_core

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.



CMake Error at CMakeLists.txt:134 (target_link_libraries):
  Target "stopped_goal_checker" links to:

    nav2_costmap_2d::nav2_costmap_2d_core

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@SteveMacenski SteveMacenski merged commit 6b2e244 into ros-navigation:main Nov 6, 2024
11 checks passed
@Ryanf55 Ryanf55 deleted the hotfix-nav2-controller-missing-costmap-2d-dep branch November 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants