Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nav2_loopback_sim dependency on transforms3d. (backport #4738) #4740

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

The package never uses it, so don't declare it.

I noticed this because I noticed that recent builds of Navigation2 on Jazzy don't work on RHEL anymore, i.e. https://build.ros2.org/job/Jsrc_el9__navigation2__rhel_9__source/ is disabled. The reason for that is that python3-transforms3d is not packaged on RHEL-9. However, it turns out that this package doesn't actually use transforms3d, so the easiest thing to do here is to remove the dependency.

Note that if accepted, this should also be backported to the jazzy branch, and a new bloom-release should be done on the buildfarm for Jazzy.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

Backport to the jazzy branch.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
    This is an automatic backport of pull request Remove nav2_loopback_sim dependency on transforms3d. #4738 done by Mergify.

The package never uses it, so don't declare it.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit a64dde1)
Copy link
Contributor Author

mergify bot commented Nov 4, 2024

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 3e3506f into jazzy Nov 4, 2024
7 of 8 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-4738 branch November 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants