Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iron Sync 6: May 23, 2024 #4366

Merged
merged 18 commits into from
May 23, 2024
Merged

Iron Sync 6: May 23, 2024 #4366

merged 18 commits into from
May 23, 2024

Commits on May 23, 2024

  1. Scale cost critic's weight when dynamically updated (#4246)

    * Scale cost critic's weight when dynamically updated
    
    Signed-off-by: pepisg <[email protected]>
    
    * sign off
    
    Signed-off-by: pepisg <[email protected]>
    
    ---------
    
    Signed-off-by: pepisg <[email protected]>
    pepisg authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    88d8667 View commit details
    Browse the repository at this point in the history
  2. Add expanding the ~/ to the full home dir of user in the path to the …

    …map yaml. (#4258)
    
    * Add user home expander of home sequence
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Add passing home dir as string instead of const char*
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Add docs
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Fix function declaration
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Fix linter issues
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Uncrustify linter
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Uncrustify linter
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    * Uncrustify linter: remove remove whitespace
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    
    ---------
    
    Signed-off-by: Wiktor Bajor <[email protected]>
    Wiktor-99 authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b867ee2 View commit details
    Browse the repository at this point in the history
  3. Implement Critic for Velocity Deadband Hardware Constraints (#4256)

    * Adding new velocity deadband critic.
    
    - add some tests
    - cast double to float
    - add new features from "main" branch
    
    - fix formating
    
    - add cost test
    - fix linting issue
    - add README
    
    Signed-off-by: Denis Sokolov <[email protected]>
    
    * Remove velocity deadband critic from defaults
    
    Signed-off-by: Denis Sokolov <[email protected]>
    
    * remove old weight
    
    Signed-off-by: Denis Sokolov <[email protected]>
    
    * fix velocity deadband critic tests
    
    Signed-off-by: Denis Sokolov <[email protected]>
    
    ---------
    
    Signed-off-by: Denis Sokolov <[email protected]>
    perchess authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ae78591 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6f38a8b View commit details
    Browse the repository at this point in the history
  5. provide message validation check API (#4276)

    * provide validation_message.hpp
    
    Signed-off-by: goes <[email protected]>
    
    * fix typo
    
    Signed-off-by: goes <[email protected]>
    
    * add test_validation_messages.cpp
    
    Signed-off-by: goes <[email protected]>
    
    * change include-order
    
    Signed-off-by: goes <[email protected]>
    
    * reformat
    
    Signed-off-by: goes <[email protected]>
    
    * update test
    
    Signed-off-by: goes <[email protected]>
    
    ---------
    
    Signed-off-by: goes <[email protected]>
    Co-authored-by: goes <[email protected]>
    2 people authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5de3188 View commit details
    Browse the repository at this point in the history
  6. [RotationShimController] rotate also on short paths (#4290)

    When the path is shorter than ´forward_sampling_distance´ the
    rotatitonShimController would directly give control to the primary
    controller to navigate to the goal. This would lead to the exact
    behavior that was tried to be fixed by the rotationShimController: "The
    result is an awkward, stuttering, or whipping around behavior" [1]. It
    often resulted in navigation failure.
    
    In this case, the controller should try to rotate towards the last point
    of the path, so that the primary controller can have a better starting
    orientation.
    
    [1] https://navigation.ros.org/tuning/index.html#rotate-in-place-behavior
    gennartan authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a425ce1 View commit details
    Browse the repository at this point in the history
  7. Add footprint clearing for static layer (#4282)

    * Add footprint clearing for static layer
    
    Signed-off-by: Tony Najjar <[email protected]>
    
    * fix flckering
    
    ---------
    
    Signed-off-by: Tony Najjar <[email protected]>
    tonynajjar authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    cf5f2fd View commit details
    Browse the repository at this point in the history
  8. Fix #4268 (#4296)

    Signed-off-by: Steve Macenski <[email protected]>
    SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5d45d82 View commit details
    Browse the repository at this point in the history
  9. Fix undefined symbols in libpf_lib.so (#4312)

    When I build `nav2_amcl` with `-Wl,--no-undefined` I noticed
    `libpf_lib.so` has undefined symbols. This PR correctly links
    `libpf_lib.so` to `libm` so all symbols can be found.
    
    You can verify this by executing the following command:
    ```
    ldd -r ./build/nav2_amcl/src/pf/libpf_lib.so
    	linux-vdso.so.1 (0x00007ffd1f8c0000)
    	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x000074e909a00000)
    	/lib64/ld-linux-x86-64.so.2 (0x000074e909e60000)
    undefined symbol: ceil	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: atan2	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: sin	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: hypot	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: cos	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: log	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: sqrt	(./build/nav2_amcl/src/pf/libpf_lib.so)
    undefined symbol: floor	(./build/nav2_amcl/src/pf/libpf_lib.so)
    ```
    
    Signed-off-by: Ramon Wijnands <[email protected]>
    Rayman authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e81c81f View commit details
    Browse the repository at this point in the history
  10. msg validation check for /initialpose in nav2_amcl (#4301)

    * add validation check for PoseWithCovarianceStamped
    
    Signed-off-by: goes <[email protected]>
    
    * remove rebundant check before
    
    Signed-off-by: goes <[email protected]>
    
    * reformat
    
    Signed-off-by: goes <[email protected]>
    
    * typo fixed
    
    Signed-off-by: goes <[email protected]>
    
    * change the type-name
    
    Signed-off-by: goes <[email protected]>
    
    * update test
    
    Signed-off-by: goes <[email protected]>
    
    * reformat
    
    Signed-off-by: goes <[email protected]>
    
    * .
    
    Signed-off-by: goes <[email protected]>
    
    * add comment
    
    Signed-off-by: goes <[email protected]>
    
    * update comment
    
    Signed-off-by: goes <[email protected]>
    
    * change header
    
    Signed-off-by: goes <[email protected]>
    
    * update test
    
    Signed-off-by: goes <[email protected]>
    
    * typo fixed
    
    Signed-off-by: goes <[email protected]>
    
    ---------
    
    Signed-off-by: goes <[email protected]>
    Co-authored-by: goes <[email protected]>
    2 people authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    91c60b7 View commit details
    Browse the repository at this point in the history
  11. 4320: Changed precision of calculations of the HybridNode MotionTable…

    …::getClosestAngularBin. (#4324)
    
    Signed-off-by: Krzysztof Pawełczyk <[email protected]>
    Co-authored-by: Krzysztof Pawełczyk <[email protected]>
    2 people authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    7b0d391 View commit details
    Browse the repository at this point in the history
  12. [LifecycleNode] add bond_heartbeat_period (#4342)

    * add bond_heartbeat_period
    
    
    Signed-off-by: Guillaume Doisy <[email protected]>
    
    * lint
    
    Signed-off-by: Guillaume Doisy <[email protected]>
    
    ---------
    
    Signed-off-by: Guillaume Doisy <[email protected]>
    Co-authored-by: Guillaume Doisy <[email protected]>
    2 people authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    43ef91a View commit details
    Browse the repository at this point in the history
  13. Update path_longer_on_approach.cpp (#4344)

    Fix the bug that isPathUpdated function will return false for the reason that it compare the timestaped between new path and old path's last pose
    
    Signed-off-by: StetroF <[email protected]>
    StetroF authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    81d2c09 View commit details
    Browse the repository at this point in the history
  14. [LifecycleManagerClient] clean set_initial_pose and navigate_to_pose (#…

    …4346)
    
    Signed-off-by: Guillaume Doisy <[email protected]>
    Co-authored-by: Guillaume Doisy <[email protected]>
    2 people authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a0911c6 View commit details
    Browse the repository at this point in the history
  15. Move projectState after getPointsInside (#4356)

    * Modify test to check fix
    
    Signed-off-by: Brice <[email protected]>
    
    * Add static polygon check before simulation
    
    Signed-off-by: Brice <[email protected]>
    
    ---------
    
    Signed-off-by: Brice <[email protected]>
    BriceRenaudeau authored and SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b332b05 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a7367bb View commit details
    Browse the repository at this point in the history
  17. bump iron to 1.2.8

    SteveMacenski committed May 23, 2024
    Configuration menu
    Copy the full SHA
    58c9eca View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e06c899 View commit details
    Browse the repository at this point in the history