-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Costmap Filters system tests #3098
Conversation
@AlexeyMerzlyakov, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
Also, added |
Try pushing this branch to the master repo instead of your fork and resubmitting the PR and see if having this come from the source repo itself gets around it. I'm curious how Circle is doing this (based on fork, user commit, branch owner, etc), it might be trivial to get around since you have write access to the main repository. |
#3120 seems to work! I made the branch and cherry picked your commit, so you're still the author of the commit but I "committed" it (?). I'm not sure if the fix is that I need to make the branch or that there needs to be someone else associated with the commit. I made you a new branch on the repo |
Unfortunately, after experiments with |
This PR fixes failing in CI
test_keepout_filter
,test_speed_filter_global
,test_speed_filter_local
tests.Basic Info
ghcr.io/ros-planning/navigation2:main
(Ubuntu 22.04, ros2 rolling), local testing at Ubuntu 20.04Description of contribution in a few bullet points
The following problems were detected on CircleCI testing with Costmap Filters system tests:
Problem1
During all Costmap Filters testcases run the following problem appear:
This appears due to double-attempt to configure already configured (by
navigation_launch.py
script)bt_navigator
node. Appeared since 35561ba. Removal ofbt_navigator
from the list of lifecycle nodes in testing scripts resolves the problem.Problem2
Adding the keepout zone to the global/local costmap for the
test_keepout_filter
test forces robot to plan on non-straight line around this zone. However, instead of bypassing of the obstacle on costmap, robot became to turn left/right in place as shown at the picture below:This behavior change is concerned with DWB part of 7872c73 commit, that increased default
prune_distance
parameter from1.0
to2.0
meters. It seems that robot tries to cut-down for the shortened distance between its actual start and pruned end point on the prepared local plan and is being getting stuck. Decreasing theprune_distance
back to the1.0
value restores robot normal behavior in keepout test (checked locally and on Docker container).Problem3
The problem appeared only on
FastRTPS
implementation fortest_keepout_filter
test . It concerned with that Keepout Filter fails to set the constmap filter info subscriber, does not receive the costmap filter info message, then misses filter mask and thus passes through keepout area. This is being indicating by following errors:This problem is most probably related to the #3014, which is yet to be resolved.
One
CycloneDDS
this issue was never detected.For Maintainers: