remove LifecycleNode's argument use_rclcpp_node

[gezp]

Signed-off-by: zhenpeng ge [email protected]

---

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	(tickets: #816)
Primary OS tested on	(Ubuntu)
Robotic platform tested on	(gazebo simulation of turtlebot3)

---

Description of contribution in a few bullet points

this is a final PR to solve #816

• remove LifecycleNode's argument use_rclcpp_node and member rclcpp_node_ which is unused currently.
• update the construction function of some nodes which derived from LifecycleNode.
• update test_costmap_topic_collision_checker.cpp which use rclcpp_node_ (like Reduce costmap_2d_ros nodes #2489).

Description of documentation updates required from your changes

update migration documentation : ros-navigation/docs.nav2.org#321

---

Future work that may be required in bullet points

For Maintainers:

• Check that any new parameters added are updated in navigation.ros.org
• Check that any significant change is added to the migration guide
• Check that any new features OR changes to existing behaviors are reflected in the tuning guide
• Check that any new functions have Doxygen added
• Check that any new features have test coverage
• Check that any new plugins is added to the plugins page
• If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

[mergify]

@gezp, please properly fill in PR template in the future. @SteveMacenski, use this instead.

• Check that any new parameters added are updated in navigation.ros.org
• Check that any significant change is added to the migration guide
• Check that any new features OR changes to existing behaviors are reflected in the tuning guide
• Check that any new functions have Doxygen added
• Check that any new features have test coverage
• Check that any new plugins is added to the plugins page
• If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists