Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added behaviour_tree as input to action nodes #2952

Merged
merged 4 commits into from
May 16, 2022

Conversation

tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented May 16, 2022


Basic Info

Info Please fill out this column
Ticket(s) this addresses #1784 (comment)
Primary OS tested on Ubuntu
Robotic platform tested on Own gazebo simulation

Description of contribution in a few bullet points

The NavigateToPose Action server accepts a behavior tree as input but its corresponding BT action node does not have a behavior_tree option. I added the behavior_tree option

Description of documentation updates required from your changes

  • Added new parameter, so need to add that to default configs and documentation page

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented May 16, 2022

@tonynajjar, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit 432b76d into ros-navigation:main May 16, 2022
@SteveMacenski
Copy link
Member

Thanks!

redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jun 30, 2022
* added BT as input to action node

* fix format

* Update navigate_to_pose_action.cpp

* Update navigate_through_poses_action.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants