Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav2_util: don't export test_msgs dependency #2943

Merged
merged 1 commit into from
May 9, 2022
Merged

nav2_util: don't export test_msgs dependency #2943

merged 1 commit into from
May 9, 2022

Conversation

lopsided98
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on nixpkgs/nix-ros-overlay
Robotic platform tested on N/A

Description of contribution in a few bullet points

Since #2827, nav2_util no longer unconditionally depends on test_msgs, but was still exporting it as a dependency. This caused downstream packages to fail to build if test_msgs is not available.

cc @alsora

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

nav2_util no longer unconditionally depends on test_msgs, but was still exporting it as a dependency. This caused downstream packages to fail to build if test_msgs was not installed.
@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

@lopsided98, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit d2ec874 into ros-navigation:main May 9, 2022
@lopsided98 lopsided98 deleted the patch-1 branch May 9, 2022 23:20
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jun 30, 2022
nav2_util no longer unconditionally depends on test_msgs, but was still exporting it as a dependency. This caused downstream packages to fail to build if test_msgs was not installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants