Delete param dumper #2908
Merged
Delete param dumper #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveMacenski, your PR has failed to build. Please check CI outputs and resolve issues. |
vinnnyr
reviewed
Apr 11, 2022
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Jun 30, 2022
* Delete param dumper * Update CMakeLists.txt * Update CMakeLists.txt * remove dump tests * revert accidental changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS 2 CLI has this available now and its not been integrated as part of any workflow within Nav2. It was created in the early days before we had a good accounting of parameters and there was no CLI that would do this for us. These are no longer true so we can deprecate this bit of the code