bitbake: Don't create a pull request #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shr-project
force-pushed
the
jansa/dry-run
branch
from
4676566
to
8870b04
Compare
herb-kuta-lge
requested changes
Feb 6, 2020
There was a problem hiding this comment.
Replace with:
Generating bitbake recipes without specifying --dry-run is not supported.\n
This is because it is almost inevitable that changes to the metadata under recipes-bbappend will be required.\n
Only when these have been made and the images build and pass the sanity test should a pull request be created.\n
shr-project
force-pushed
the
jansa/dry-run
branch
from
8870b04
to
88de88d
Compare
There was a problem hiding this comment.
Commit message suggestion:
bitbake/run.py: Require --dry-run
- There are usually are some changes needed to manually adjust the .bbappends to build everything
correctly with updated recipes. Prevent people from accidentally creating pull requests
on GitHub before this is done by requiring that --dry-run be specified.
shr-project
force-pushed
the
jansa/dry-run
branch
2 times, most recently
from
7de4a97
to
f1f5c99
Compare
herb-kuta-lge
previously approved these changes
Feb 13, 2020
herb-kuta-lge
changed the title
herb-kuta-lge
dismissed
their stale review
The README.md needs to be updated.
herb-kuta-lge
requested changes
Feb 13, 2020
shr-project
force-pushed
the
jansa/dry-run
branch
from
f1f5c99
to
3e01430
Compare
herb-kuta-lge
requested changes
Feb 14, 2020
shr-project
force-pushed
the
jansa/dry-run
branch
2 times, most recently
from
d7fc7a3
to
9648c6e
Compare
herb-kuta-lge
requested changes
Mar 20, 2020
shr-project
force-pushed
the
jansa/dry-run
branch
2 times, most recently
from
7153976
to
49cbad3
Compare
herb-kuta-lge
approved these changes
Mar 21, 2020
herb-kuta-lge
requested changes
Mar 22, 2020
|
@allenh1 < Should an issue be created for this PR? |
shr-project
force-pushed
the
jansa/dry-run
branch
from
49cbad3
to
d9d4f4c
Compare
* There are usually are some changes needed to manually adjust the .bbappends to build everything correctly with updated recipes. Prevent people from accidentally creating pull requests on GitHub before this is done by requiring that --dry-run be specified. Signed-off-by: Martin Jansa <[email protected]>
shr-project
force-pushed
the
jansa/dry-run
branch
from
d9d4f4c
to
8261618
Compare
herb-kuta-lge
approved these changes
Mar 22, 2020
There was a problem hiding this comment.
Waiting to see if @allenh1 wants an issue created for this PR.
No, I'm not too concerned about it. Feel free to squash & merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly with the updated recipes, prevent people from accidentally creating pull-requests
on github before their changes and is ready to build (or even parse correctly)
Signed-off-by: Martin Jansa [email protected]