Skip to content

Commit

Permalink
bitbake/run.py: Require --dry-run
Browse files Browse the repository at this point in the history
* There are usually are some changes needed to manually adjust the
  .bbappends to build everything correctly with updated recipes.
  Prevent people from accidentally creating pull requests on GitHub
  before this is done by requiring that --dry-run be specified.

Signed-off-by: Martin Jansa <[email protected]>
  • Loading branch information
shr-project committed Feb 11, 2020
1 parent e050d9f commit f1f5c99
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions superflore/generators/bitbake/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ def main():
if not args.dry_run:
if 'SUPERFLORE_GITHUB_TOKEN' not in os.environ:
raise NoGitHubAuthToken()
err('Generating bitbake recipes without specifying --dry-run is not '
'supported.\n This is because it is almost inevitable that '
'changes to the metadata under recipes-bbappend will be required.'
'\nOnly when these have been made and the images build and pass '
'the sanity test should a pull request be created.\n')
sys.exit(1)
if args.pr_only:
if args.dry_run:
parser.error('Invalid args! cannot dry-run and file PR')
Expand Down

0 comments on commit f1f5c99

Please sign in to comment.